Messages in this thread | | | Date | Tue, 16 Jun 2020 09:00:56 +0100 | From | Lee Jones <> | Subject | Re: [PATCH v2 2/4] mfd: arizona: Ensure 32k clock is put on driver unbind and error |
| |
On Mon, 15 Jun 2020, Charles Keepax wrote:
> Whilst it doesn't matter if the internal 32k clock register settings > are cleaned up on exit, as the part will be turned off losing any > settings, hence the driver hasn't historially bothered. The external > clock should however be cleaned up, as it could cause clocks to be > left on, and will at best generate a warning on unbind. > > Add clean up on both the probe error path and unbind for the 32k > clock. > > Fixes: cdd8da8cc66b ("mfd: arizona: Add gating of external MCLKn clocks") > Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com> > --- > > No changes since v1. > > Thanks, > Charles > > drivers/mfd/arizona-core.c | 18 ++++++++++++++++++ > 1 file changed, 18 insertions(+)
Applied, thanks.
-- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog
| |