Messages in this thread | ![/](/images/icornerl.gif) | | From | "Kirsher, Jeffrey T" <> | Subject | RE: [PATCH] e1000e: add ifdef to avoid dead code | Date | Tue, 16 Jun 2020 21:20:07 +0000 |
| |
> -----Original Message----- > From: Eric Dumazet <eric.dumazet@gmail.com> > On 6/13/20 11:11 PM, Greg Thelen wrote: > > Commit e086ba2fccda ("e1000e: disable s0ix entry and exit flows for ME > > systems") added e1000e_check_me() but it's only called from > > CONFIG_PM_SLEEP protected code. Thus builds without CONFIG_PM_SLEEP > > see: > > drivers/net/ethernet/intel/e1000e/netdev.c:137:13: warning: > > 'e1000e_check_me' defined but not used [-Wunused-function] > > > > Add CONFIG_PM_SLEEP ifdef guard to avoid dead code. > > > > Fixes: e086ba2fccda ("e1000e: disable s0ix entry and exit flows for ME > > systems") > > Signed-off-by: Greg Thelen <gthelen@google.com> > > --- > > drivers/net/ethernet/intel/e1000e/netdev.c | 2 ++ > > 1 file changed, 2 insertions(+) > > Reviewed-by: Eric Dumazet <edumazet@google.com> [Kirsher, Jeffrey T]
This patch is not necessary, after Arnd's patch. Here is his patch: http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20200527134716.948148-1-arnd@arndb.de/ and I will be pushing it to Dave's net tree later tonight.
| ![\](/images/icornerr.gif) |