Messages in this thread | ![/](/images/icornerl.gif) | | Date | Tue, 16 Jun 2020 11:30:56 -0700 | From | Kees Cook <> | Subject | Re: [PATCH][next] kexec_file: Use array_size() helper in memcpy() |
| |
On Tue, Jun 16, 2020 at 01:20:41PM -0500, Gustavo A. R. Silva wrote: > Use array_size() instead of the open-coded version in memcpy(). These > sorts of multiplication factors need to be wrapped in array_size(). > > Also, while there, use the preferred form for passing a size of a struct. > The alternative form where struct name is spelled out hurts readability > and introduces an opportunity for a bug when the pointer variable type is > changed but the corresponding sizeof that is passed as argument is not. > > This issue was found with the help of Coccinelle and, audited and fixed > manually. > > Addresses-KSPP-ID: https://github.com/KSPP/linux/issues/83 > Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Reviewed-by: Kees Cook <keescook@chromium.org>
-- Kees Cook
| ![\](/images/icornerr.gif) |