Messages in this thread | | | Subject | Re: [PATCH v1] ARM: bcm2835: Fix integer overflow in rpi_firmware_print_firmware_revision() | From | Nicolas Saenz Julienne <> | Date | Tue, 16 Jun 2020 18:42:00 +0200 |
| |
On Tue, 2020-06-16 at 19:31 +0300, Andy Shevchenko wrote: > time64_t is 64-bit width type, we are not supposed to supply lesser ones > as in the case of rpi_firmware_print_firmware_revision() after the commit > 4a60f58ee002 ("ARM: bcm2835: Switch to use %ptT"). Use temporary variable > of time64_t type to correctly handle lesser types. > > Fixes: 4a60f58ee002 ("ARM: bcm2835: Switch to use %ptT") > Reported-by: Stefan Wahren <wahrenst@gmx.net> > Reported-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > Cc: Petr Mladek <pmladek@suse.com> > Cc: Steven Rostedt <rostedt@goodmis.org> > Cc: Sergey Senozhatsky <sergey.senozhatsky@gmail.com> > ---
Reviewed-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de> Tested-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
If this doesn't fit the printk tree I don't mind taking it trough the rpi soc tree.
I'll also update the MAINTAINERS file so the firmware driver isn't orphaned.
Thanks! Nicolas
[unhandled content-type:application/pgp-signature] | |