lkml.org 
[lkml]   [2020]   [Jun]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 079/134] crypto: cavium/nitrox - Fix nitrox_get_first_device() when ndevlist is fully iterated
    Date
    From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>

    commit 320bdbd816156f9ca07e5fed7bfb449f2908dda7 upstream.

    When a list is completely iterated with 'list_for_each_entry(x, ...)', x is
    not NULL at the end.

    While at it, remove a useless initialization of the ndev variable. It
    is overridden by 'list_for_each_entry'.

    Fixes: f2663872f073 ("crypto: cavium - Register the CNN55XX supported crypto algorithms.")
    Cc: <stable@vger.kernel.org>
    Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
    Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/crypto/cavium/nitrox/nitrox_main.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    --- a/drivers/crypto/cavium/nitrox/nitrox_main.c
    +++ b/drivers/crypto/cavium/nitrox/nitrox_main.c
    @@ -278,7 +278,7 @@ static void nitrox_remove_from_devlist(s

    struct nitrox_device *nitrox_get_first_device(void)
    {
    - struct nitrox_device *ndev = NULL;
    + struct nitrox_device *ndev;

    mutex_lock(&devlist_lock);
    list_for_each_entry(ndev, &ndevlist, list) {
    @@ -286,7 +286,7 @@ struct nitrox_device *nitrox_get_first_d
    break;
    }
    mutex_unlock(&devlist_lock);
    - if (!ndev)
    + if (&ndev->list == &ndevlist)
    return NULL;

    refcount_inc(&ndev->refcnt);

    \
     
     \ /
      Last update: 2020-06-16 18:17    [W:4.026 / U:0.088 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site