lkml.org 
[lkml]   [2020]   [Jun]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.7 053/163] io_uring: fix flush req->refs underflow
    Date
    From: Pavel Begunkov <asml.silence@gmail.com>

    commit 4518a3cc273cf82efdd36522fb1f13baad173c70 upstream.

    In io_uring_cancel_files(), after refcount_sub_and_test() leaves 0
    req->refs, it calls io_put_req(), which would also put a ref. Call
    io_free_req() instead.

    Cc: stable@vger.kernel.org
    Fixes: 2ca10259b418 ("io_uring: prune request from overflow list on flush")
    Signed-off-by: Pavel Begunkov <asml.silence@gmail.com>
    Signed-off-by: Jens Axboe <axboe@kernel.dk>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    fs/io_uring.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/fs/io_uring.c
    +++ b/fs/io_uring.c
    @@ -7390,7 +7390,7 @@ static void io_uring_cancel_files(struct
    * all we had, then we're done with this request.
    */
    if (refcount_sub_and_test(2, &cancel_req->refs)) {
    - io_put_req(cancel_req);
    + io_free_req(cancel_req);
    finish_wait(&ctx->inflight_wait, &wait);
    continue;
    }

    \
     
     \ /
      Last update: 2020-06-16 18:13    [W:2.573 / U:0.828 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site