lkml.org 
[lkml]   [2020]   [Jun]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.6 077/161] ACPI: sysfs: Fix reference count leak in acpi_sysfs_add_hotplug_profile()
    Date
    From: Qiushi Wu <wu000273@umn.edu>

    commit 6e6c25283dff866308c87b49434c7dbad4774cc0 upstream.

    kobject_init_and_add() takes reference even when it fails.
    Thus, when kobject_init_and_add() returns an error,
    kobject_put() must be called to properly clean up the kobject.

    Fixes: 3f8055c35836 ("ACPI / hotplug: Introduce user space interface for hotplug profiles")
    Signed-off-by: Qiushi Wu <wu000273@umn.edu>
    Cc: 3.10+ <stable@vger.kernel.org> # 3.10+
    Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/acpi/sysfs.c | 4 +++-
    1 file changed, 3 insertions(+), 1 deletion(-)

    --- a/drivers/acpi/sysfs.c
    +++ b/drivers/acpi/sysfs.c
    @@ -993,8 +993,10 @@ void acpi_sysfs_add_hotplug_profile(stru

    error = kobject_init_and_add(&hotplug->kobj,
    &acpi_hotplug_profile_ktype, hotplug_kobj, "%s", name);
    - if (error)
    + if (error) {
    + kobject_put(&hotplug->kobj);
    goto err_out;
    + }

    kobject_uevent(&hotplug->kobj, KOBJ_ADD);
    return;

    \
     
     \ /
      Last update: 2020-06-16 18:02    [W:2.158 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site