lkml.org 
[lkml]   [2020]   [Jun]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [RFC v2 2/3] drivers: nvmem: Add QTI qfprom-efuse support
From
Date

I think Doug already covered most of the comments and his fixes seems be
in right direction.

On 11/06/2020 10:48, Ravi Kumar Bokka wrote:
> + qfpraw = platform_get_resource_byname(pdev, IORESOURCE_MEM, "raw");
> +
> + priv->qfpraw = devm_ioremap_resource(dev, qfpraw);
> + if (IS_ERR(priv->qfpraw)) {

General comment for up-streaming is that your patch should not break
whats in mainline, Your patch is totally ignoring!! Please be mindful
while doing changes to drivers which are used by other platforms.

--srini
> + ret = PTR_ERR(priv->qfpraw);
> + goto err;
> + }
> +
> + qfpconf = platform_get_resource_byname(pdev, IORESOURCE_MEM, "conf");
> +
> + priv->qfpconf = devm_ioremap_resource(dev, qfpconf);
> + if (IS_ERR(priv->qfpconf)) {
> + ret = PTR_ERR(priv->qfpconf);
> + goto err;
> + }
> +
> + qfpcorrected = platform_get_resource_byname(pdev, IORESOURCE_MEM,
> + "corrected");
> +
> + priv->qfpcorrected = devm_ioremap_resource(dev, qfpcorrected);
> + if (IS_ERR(priv->qfpcorrected)) {
> + ret = PTR_ERR(priv->qfpcorrected);
> + goto err;
> + }

\
 
 \ /
  Last update: 2020-06-15 11:57    [W:0.270 / U:0.196 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site