lkml.org 
[lkml]   [2020]   [Jun]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v2 2/3] spi: spi-fsl-dspi: Initialize completion before possible interrupt
    Date
    The interrupt handler calls completion and is IRQ requested before the
    completion is initialized. Logically it should be the other way.

    Fixes: 4f5ee75ea171 ("spi: spi-fsl-dspi: Replace interruptible wait queue with a simple completion")
    Cc: <stable@vger.kernel.org>
    Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>

    ---

    Changes since v1:
    1. Rework the commit msg.
    ---
    drivers/spi/spi-fsl-dspi.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    diff --git a/drivers/spi/spi-fsl-dspi.c b/drivers/spi/spi-fsl-dspi.c
    index 023e05c53b85..080c5624bd1e 100644
    --- a/drivers/spi/spi-fsl-dspi.c
    +++ b/drivers/spi/spi-fsl-dspi.c
    @@ -1385,6 +1385,8 @@ static int dspi_probe(struct platform_device *pdev)
    goto poll_mode;
    }

    + init_completion(&dspi->xfer_done);
    +
    ret = devm_request_irq(&pdev->dev, dspi->irq, dspi_interrupt,
    IRQF_SHARED, pdev->name, dspi);
    if (ret < 0) {
    @@ -1392,8 +1394,6 @@ static int dspi_probe(struct platform_device *pdev)
    goto out_clk_put;
    }

    - init_completion(&dspi->xfer_done);
    -
    poll_mode:

    if (dspi->devtype_data->trans_mode == DSPI_DMA_MODE) {
    --
    2.7.4
    \
     
     \ /
      Last update: 2020-06-15 10:08    [W:8.431 / U:1.400 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site