lkml.org 
[lkml]   [2020]   [Jun]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 1/4] proc/bootconfig: Fix to use correct quotes for value
From
Date
On 6/15/20 2:21 PM, Steven Rostedt wrote:
> On Mon, 15 Jun 2020 12:24:00 -0700
> Joe Perches <joe@perches.com> wrote:
>
>>> Hmm, shouldn't the above have the upside-down xmas tree format?
>>>
>>> struct xbc_node *leaf, *vnode;
>>> char *key, *end = dst + size;
>>> const char *val;
>>> char q;
>>> int ret = 0;
>>
>> Please don't infect kernel sources with that style oddity.
>
> What do you mean? It's already "infected" all over the kernel, (has
> been for years!) and I kinda like it. It makes reading variables much
> easier on the eyes, and as I get older, that means a lot more ;-)

Yeah, there is some infection, more in some places than others,
but I agree with Joe -- it's not needed or wanted by some of us.


--
~Randy

\
 
 \ /
  Last update: 2020-06-16 00:31    [W:0.234 / U:0.168 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site