lkml.org 
[lkml]   [2020]   [Jun]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 1/2] dt-bindings: net: dsa: qca8k: document SGMII properties
    On Mon, Jun 15, 2020 at 11:45:16AM -0600, Rob Herring wrote:
    > On Fri, Jun 05, 2020 at 07:10:02PM +0100, Jonathan McDowell wrote:
    > > This patch documents the qca8k's SGMII related properties that allow
    > > configuration of the SGMII port.
    > >
    > > Signed-off-by: Jonathan McDowell <noodles@earth.li>
    > > ---
    > > Documentation/devicetree/bindings/net/dsa/qca8k.txt | 4 ++++
    > > 1 file changed, 4 insertions(+)
    > >
    > > diff --git a/Documentation/devicetree/bindings/net/dsa/qca8k.txt b/Documentation/devicetree/bindings/net/dsa/qca8k.txt
    > > index ccbc6d89325d..9e7d74a248ad 100644
    > > --- a/Documentation/devicetree/bindings/net/dsa/qca8k.txt
    > > +++ b/Documentation/devicetree/bindings/net/dsa/qca8k.txt
    > > @@ -11,7 +11,11 @@ Required properties:
    > >
    > > Optional properties:
    > >
    > > +- disable-serdes-autoneg: Boolean, disables auto-negotiation on the SerDes
    > > - reset-gpios: GPIO to be used to reset the whole device
    > > +- sgmii-delay: Boolean, presence delays SGMII clock by 2ns
    > > +- sgmii-mode: String, operation mode of the SGMII interface.
    > > + Supported values are: "basex", "mac", "phy".
    >
    > Either these should be common properties and documented in a common
    > spot or they need vendor prefixes. They seem like they former to me
    > (though 'sgmii-delay' would need to be more general and take a time).

    I've managed to spin a subsequent revision which avoids the need for a
    device tree change, based on comments similar to yours. I'll keep them
    in mind should it become necessary to re-introduce the DT options.

    J.

    --
    ] https://www.earth.li/~noodles/ [] I'm a creep, I'm a weirdo, what [
    ] PGP/GPG Key @ the.earth.li [] the hell am I doing here? [
    ] via keyserver, web or email. [] [
    ] RSA: 4096/0x94FA372B2DA8B985 [] [

    \
     
     \ /
      Last update: 2020-06-15 20:16    [W:2.291 / U:0.020 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site