Messages in this thread | | | From | Linus Torvalds <> | Date | Mon, 15 Jun 2020 09:56:59 -0700 | Subject | Re: [PATCH 10/13] integrity/ima: switch to using __kernel_read |
| |
On Mon, Jun 15, 2020 at 9:46 AM Linus Torvalds <torvalds@linux-foundation.org> wrote: > > It worries me that you're making these kinds of transformations where > the comments imply it's a no-op, but the actual code doesn't agree.
Note that it's not that I think the FMODE_READ check is necessarily _needed_. It's more the discrepancy between the commit message and the code change that I don't like.
The commit message implies that __kernel_read() has _more_ checks than the checks done by integrity_kernel_read(). But it looks like they aren't so much "more" as they are just "different".
Linus
| |