lkml.org 
[lkml]   [2020]   [Jun]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] memory: tegra: Avoid double error messaging when IRQ absent
From
Date
11.06.2020 22:07, Keyur Patel пишет:
> Since the commit 7723f4c ("driver core: platform: Add an error message
> to platform_get_irq*()") platform_get_irq() started issuing an error message.
> Thus, there is no need to have the same in the driver.
>
> Signed-off-by: Keyur Patel <iamkeyur96@gmail.com>
> ---
> drivers/memory/tegra/mc.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/memory/tegra/mc.c b/drivers/memory/tegra/mc.c
> index ec8403557ed4..f519c0987485 100644
> --- a/drivers/memory/tegra/mc.c
> +++ b/drivers/memory/tegra/mc.c
> @@ -659,10 +659,8 @@ static int tegra_mc_probe(struct platform_device *pdev)
> }
>
> mc->irq = platform_get_irq(pdev, 0);
> - if (mc->irq < 0) {
> - dev_err(&pdev->dev, "interrupt not specified\n");
> + if (mc->irq < 0)
> return mc->irq;
> - }
>
> WARN(!mc->soc->client_id_mask, "missing client ID mask for this SoC\n");
>
>

Reviewed-by: Dmitry Osipenko <digetx@gmail.com>

\
 
 \ /
  Last update: 2020-06-12 16:16    [W:0.038 / U:0.568 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site