lkml.org 
[lkml]   [2020]   [Jun]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v4 2/2] phy: intel: Add Keem Bay eMMC PHY support
On Fri, Jun 12, 2020 at 11:53:59AM +0800, Wan Ahmad Zainie wrote:
> Add support for eMMC PHY on Intel Keem Bay SoC.

Pretty much good, my comments below.

...

> +config PHY_KEEMBAY_EMMC
> + tristate "Intel Keem Bay EMMC PHY Driver"

> + depends on OF

No compile test?

> + select GENERIC_PHY
> + select REGMAP_MMIO
> + help
> + Enable this to support the Keem Bay EMMC PHY.

Please, be more verbose here, do I, as a user, need this? What will be the module name?

--
With Best Regards,
Andy Shevchenko


\
 
 \ /
  Last update: 2020-06-12 15:22    [W:0.040 / U:0.380 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site