lkml.org 
[lkml]   [2020]   [Jun]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] drm/mediatek: remove unnecessary conversion to bool
From
Date
On 2020-06-12 13:40, Bernard Zhao wrote:
> In function mtk_dsi_clk_hs_state, remove unnecessary conversion
> to bool return, this change is to make the code a bit readable.
>
> Signed-off-by: Bernard Zhao <bernard@vivo.com>
> ---
> drivers/gpu/drm/mediatek/mtk_dsi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c b/drivers/gpu/drm/mediatek/mtk_dsi.c
> index 270bf22c98fe..4491e64b3f06 100644
> --- a/drivers/gpu/drm/mediatek/mtk_dsi.c
> +++ b/drivers/gpu/drm/mediatek/mtk_dsi.c
> @@ -319,7 +319,7 @@ static bool mtk_dsi_clk_hs_state(struct mtk_dsi *dsi)
> u32 tmp_reg1;
>
> tmp_reg1 = readl(dsi->regs + DSI_PHY_LCCON);
> - return ((tmp_reg1 & LC_HS_TX_EN) == 1) ? true : false;
> + return ((tmp_reg1 & LC_HS_TX_EN) == 1);

FWIW the "== 1" is also redundant, not to mention a little confusing -
unless you go and look up the definition of LC_HS_TX_EN, it looks like
this is doing something more than simply testing if a single bit is set.

Robin.

> }
>
> static void mtk_dsi_clk_hs_mode(struct mtk_dsi *dsi, bool enter)
>

\
 
 \ /
  Last update: 2020-06-12 15:09    [W:0.142 / U:0.412 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site