Messages in this thread | | | From | Linus Torvalds <> | Date | Wed, 8 Apr 2020 21:11:30 -0700 | Subject | Re: [GIT PULL] libnvdimm for v5.7 |
| |
On Tue, Apr 7, 2020 at 1:12 PM Dan Williams <dan.j.williams@intel.com> wrote: > > mm/memremap_pages: Introduce memremap_compat_align()
Why is this an exported function that just returns a constant?
Why isn't it just a #define (or inline) in a header file?
Yes, yes, it would need to be conditional on not having that CONFIG_ARCH_HAS_MEMREMAP_COMPAT_ALIGN, but it does look strange.
I've pulled it, since it doesn't matter that much, but I find it silly to have full-fledged functions - and exported them GPL-only - to return a constant. Crazy.
Linus
| |