Messages in this thread | | | From | Aurabindo Pillai <> | Date | Wed, 8 Apr 2020 19:18:44 -0400 | Subject | Re: [PATCH] drm/amd/amdgpu: add prefix for pr_* prints |
| |
Hi Joe,
On Wed, Apr 8, 2020 at 11:37 AM Joe Perches <joe@perches.com> wrote: > > All the embedded uses of "amdgpu:" in logging > messages should also be deleted. > > $ git grep -P '(?:dev_|pr_).*"amdgpu:' drivers/gpu/drm/amd/amdgpu/ > drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c: pr_err("amdgpu: failed to validate PT BOs\n"); > drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c: pr_err("amdgpu: failed to validate PD\n"); > drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c: pr_err("amdgpu: failed to kmap PD, ret=%d\n", ret); > drivers/gpu/drm/amd/amdgpu/amdgpu_device.c: pr_info("amdgpu: switched on\n"); > drivers/gpu/drm/amd/amdgpu/amdgpu_device.c: pr_info("amdgpu: switched off\n"); > drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c: dev_dbg(adev->dev, "amdgpu: using MSI/MSI-X.\n"); > drivers/gpu/drm/amd/amdgpu/gmc_v6_0.c: dev_warn(adev->dev, "amdgpu: No suitable DMA available.\n"); > drivers/gpu/drm/amd/amdgpu/gmc_v7_0.c: pr_warn("amdgpu: No suitable DMA available\n"); > drivers/gpu/drm/amd/amdgpu/gmc_v8_0.c: pr_warn("amdgpu: No suitable DMA available\n"); > > >
Thanks for the heads up, I shall submit another set with those changes you suggested.
--
Thanks and Regards,
Aurabindo J Pillai https://aurabindo.in
| |