lkml.org 
[lkml]   [2020]   [Apr]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [RFC] net/mlx5: Fix failing fw tracer allocation on s390
Date
On Wed, 2020-04-08 at 10:06 +0200, Niklas Schnelle wrote:
> On 4/7/20 5:12 PM, Markus Elfring wrote:
> > > On s390 FORCE_MAX_ZONEORDER is 9 instead of 11, thus a larger
> > > kzalloc()
> > > allocation as done for the firmware tracer will always fail.
> >
> > How do you think about to add the tag “Fixes” to the final change
> > description?
> >
> > Regards,
> > Markus
> >
> You're right that makes a lot of sense, thanks! I guess this should
> reference
> the commit that introduced the debug trace, right?
>

probably, just git blame this line:
tracer = kzalloc(sizeof(*tracer), GFP_KERNEL);

\
 
 \ /
  Last update: 2020-04-08 21:39    [W:0.054 / U:0.316 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site