Messages in this thread | | | Subject | Re: [v2] iio: core: move 'indio_dev->info' null check first | From | Markus Elfring <> | Date | Tue, 7 Apr 2020 14:12:51 +0200 |
| |
> Doesn't fix anything.
You would like to change something for a specific reason. Thus please omit this sentence.
> Just moves this to be the first check, as it's very …
Wording alternative: Move a null pointer check to the beginning of this function implementation.
> This is a minor optimization, since '__iio_device_register()' will waste > fewer validation cycles in case 'indio_dev->info' is NULL.
How do you think about to use the text “iio: core: Improve input parameter validation in __iio_device_register()” as a commit subject?
Regards, Markus
| |