lkml.org 
[lkml]   [2020]   [Apr]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v2 3/7] arm64: dts: allwinner: h6: Add CPU Operating Performance Points table
    On Mon, Apr 06, 2020 at 08:03:34PM +0200, Clément Péron wrote:
    > > > --- a/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi
    > > > +++ b/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi
    > > > @@ -253,6 +253,10 @@
    > > > #address-cells = <1>;
    > > > #size-cells = <1>;
    > > >
    > > > + speedbin_efuse: speed@1c {
    > > > + reg = <0x1c 0x4>;
    > > > + };
    > > > +
    > >
    > > You should order this by address, so after the THS calibration. Also,
    > > using a less generic node name than "speed" would be great. What about
    > > soc-bin ?
    >
    > Indeed it's too generic.
    > I will keep coherency with i.MX8 and use "cpu_speed_grade"

    It works for me, but remember that you can't use underscores :)

    Maxime
    [unhandled content-type:application/pgp-signature]
    \
     
     \ /
      Last update: 2020-04-07 10:47    [W:5.586 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site