Messages in this thread | | | Date | Tue, 7 Apr 2020 18:20:28 -0700 | From | Nathan Chancellor <> | Subject | Re: [PATCH] ARC: [plat-hsdk]: fix USB regression |
| |
On Tue, Apr 07, 2020 at 07:19:33PM +0300, Eugeniy Paltsev wrote: > As of today the CONFIG_USB isn't explicitly present in HSDK defconfig > as it is implicitly forcibly enabled by UDL driver which selects CONFIG_USB > in its kconfig. > The commit 5d50bd440bc2 ("drm/udl: Make udl driver depend on CONFIG_USB") > reverse the dependencies between UDL and USB so UDL now depends on > CONFIG_USB and not selects it. This introduces regression for ARC HSDK > board as HSDK defconfig wasn't adjusted and now it misses USB support > due to lack of CONFIG_USB enabled. > > Fix that. > > Fixes: 5d50bd440bc2 ("drm/udl: Make udl driver depend on CONFIG_USB") > Signed-off-by: Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com> > --- > arch/arc/configs/hsdk_defconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arc/configs/hsdk_defconfig b/arch/arc/configs/hsdk_defconfig > index 0974226fab55..f79c15892704 100644 > --- a/arch/arc/configs/hsdk_defconfig > +++ b/arch/arc/configs/hsdk_defconfig > @@ -65,6 +65,7 @@ CONFIG_DRM_UDL=y > CONFIG_DRM_ETNAVIV=y > CONFIG_FB=y > CONFIG_FRAMEBUFFER_CONSOLE=y > +CONFIG_USB
Shouldn't this be CONFIG_USB=y?
As it stands, this patch does nothing.
Cheers, Nathan
| |