Messages in this thread | | | Date | Wed, 8 Apr 2020 08:59:47 +0900 | From | Masami Hiramatsu <> | Subject | Re: [PATCH 3/4] x86,module: Detect VMX vs SLD conflicts |
| |
Hi Andrew,
On Tue, 7 Apr 2020 18:16:58 +0100 Andrew Cooper <andrew.cooper3@citrix.com> wrote:
> On 07/04/2020 17:51, Masami Hiramatsu wrote: > > diff --git a/tools/arch/x86/tools/gen-insn-attr-x86.awk b/tools/arch/x86/tools/gen-insn-attr-x86.awk > > index d74d9e605723..ade80796453c 100644 > > --- a/tools/arch/x86/tools/gen-insn-attr-x86.awk > > +++ b/tools/arch/x86/tools/gen-insn-attr-x86.awk > > @@ -70,6 +70,8 @@ BEGIN { > > mmx_expr = "^(emms|fxsave|fxrstor|ldmxcsr|stmxcsr)" # MMX/SSE nmemonics lacking operands > > fpu_expr = "^x87" > > > > + vmx_expr = "^VM.*" # All mnemonic start with "VM" are VMX instructions > > Not really. > > VMMCALL, VMLOAD, VMSAVE and VMRUN are SVM instructions.
Here VMX will include SVM instructions. Would we need to distinguish them in this context? (Or INAT_VIRT might be politically correct :) )
> VMASKMOV is a AVX instruction.
Good point. That instruction is written in lowercase "vmaskmov" in x86-opcode-map.txt. (Maybe it is better to note it in x86-opcode-map.txt)
Thank you,
-- Masami Hiramatsu <mhiramat@kernel.org>
| |