Messages in this thread | | | Date | Thu, 2 Apr 2020 14:30:02 +0200 | From | Robert Richter <> | Subject | Re: [PATCH] EDAC/altera:Use platform_get_irq_optional() |
| |
On 02.04.20 19:27:40, Tang Bin wrote: > In order to simply code,because platform_get_irq() already has > dev_err() message.
I don't see a difference other than hiding a -EPROBE_DEFER error message. If that is your intention, please update subject and description accordingly.
Thanks,
-Robert
> > Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com> > --- > drivers/edac/altera_edac.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/edac/altera_edac.c b/drivers/edac/altera_edac.c > index e91cf1147..e12bad148 100644 > --- a/drivers/edac/altera_edac.c > +++ b/drivers/edac/altera_edac.c > @@ -2099,7 +2099,7 @@ static int altr_edac_a10_probe(struct platform_device *pdev) > return -ENOMEM; > } > > - edac->sb_irq = platform_get_irq(pdev, 0); > + edac->sb_irq = platform_get_irq_optional(pdev, 0); > if (edac->sb_irq < 0) { > dev_err(&pdev->dev, "No SBERR IRQ resource\n"); > return edac->sb_irq; > @@ -2134,7 +2134,7 @@ static int altr_edac_a10_probe(struct platform_device *pdev) > } > } > #else > - edac->db_irq = platform_get_irq(pdev, 1); > + edac->db_irq = platform_get_irq_optional(pdev, 1); > if (edac->db_irq < 0) { > dev_err(&pdev->dev, "No DBERR IRQ resource\n"); > return edac->db_irq; > -- > 2.20.1.windows.1 > > >
| |