Messages in this thread | | | Subject | Re: [PATCH v4 4/4] Revert "scsi: core: run queue if SCSI device queue isn't ready and queue is idle" | From | "Martin K. Petersen" <> | Date | Mon, 13 Apr 2020 13:51:22 -0400 |
| |
Douglas,
> This reverts commit 7e70aa789d4a0c89dbfbd2c8a974a4df717475ec. > > Now that we have the patches ("blk-mq: In blk_mq_dispatch_rq_list() > "no budget" is a reason to kick") and ("blk-mq: Rerun dispatching in > the case of budget contention") we should no longer need the fix in > the SCSI code. Revert it, resolving conflicts with other patches that > have touched this code. > > With this revert (and the two new patches) I can run the script that > was in commit 7e70aa789d4a ("scsi: core: run queue if SCSI device > queue isn't ready and queue is idle") in a loop with no failure. If I > do this revert without the two new patches I can easily get a failure. > > Signed-off-by: Douglas Anderson <dianders@chromium.org>
Looks good to me, never really liked the original commit.
Acked-by: Martin K. Petersen <martin.petersen@oracle.com>
-- Martin K. Petersen Oracle Linux Engineering
| |