lkml.org 
[lkml]   [2020]   [Apr]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v2 2/2] remoteproc: core: Prevent sleep when rproc crashes
    On Wed 08 Apr 15:18 PDT 2020, Siddharth Gupta wrote:

    > Remoteproc recovery should be fast and any delay will have an impact on the
    > user-experience. Add a wakeup source to remoteproc which ensures that the
    > system does not go into idle state while a remoteproc is recovering, thus
    > prevent any delays that might occur during system resume.
    >

    This is better, but I think it can be reworded further to show that it's
    not a matter of making it "fast", it's a matter of preventing suspend
    from interrupting the recovery of a remoteproc.

    > Signed-off-by: Siddharth Gupta <sidgup@codeaurora.org>
    > ---
    > drivers/remoteproc/qcom_q6v5_pas.c | 1 +
    > drivers/remoteproc/remoteproc_core.c | 4 ++++
    > 2 files changed, 5 insertions(+)
    >
    > diff --git a/drivers/remoteproc/qcom_q6v5_pas.c b/drivers/remoteproc/qcom_q6v5_pas.c
    > index 7a63efb..6bb2c7d 100644
    > --- a/drivers/remoteproc/qcom_q6v5_pas.c
    > +++ b/drivers/remoteproc/qcom_q6v5_pas.c
    > @@ -401,6 +401,7 @@ static int adsp_probe(struct platform_device *pdev)
    >
    > adsp = (struct qcom_adsp *)rproc->priv;
    > adsp->dev = &pdev->dev;
    > + device_wakeup_enable(adsp->dev);

    Move this 5 lines down and give it an empty line before and after.

    > adsp->rproc = rproc;
    > adsp->pas_id = desc->pas_id;
    > adsp->has_aggre2_clk = desc->has_aggre2_clk;
    > diff --git a/drivers/remoteproc/remoteproc_core.c b/drivers/remoteproc/remoteproc_core.c
    > index 9f99fe2..19a360d 100644
    > --- a/drivers/remoteproc/remoteproc_core.c
    > +++ b/drivers/remoteproc/remoteproc_core.c
    > @@ -1729,6 +1729,8 @@ static void rproc_crash_handler_work(struct work_struct *work)
    >
    > if (!rproc->recovery_disabled)
    > rproc_trigger_recovery(rproc);
    > +
    > + pm_relax(rproc->dev.parent);
    > }
    >
    > /**
    > @@ -2273,6 +2275,8 @@ void rproc_report_crash(struct rproc *rproc, enum rproc_crash_type type)
    > return;
    > }
    >

    /* Prevent suspend while the remoteproc is being recovered */


    PS. This patch is unrelated to patch 1/2, so please resubmit it
    separately.

    Regards,
    Bjorn

    > + pm_stay_awake(rproc->dev.parent);
    > +
    > dev_err(&rproc->dev, "crash detected in %s: type %s\n",
    > rproc->name, rproc_crash_to_string(type));
    >
    > --
    > Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
    > a Linux Foundation Collaborative Project

    \
     
     \ /
      Last update: 2020-04-11 04:27    [W:4.396 / U:0.116 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site