lkml.org 
[lkml]   [2020]   [Mar]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [RFC][PATCH] soc: qcom: rpmpd: Allow RPMPD driver to be loaded as a module
From
Date

>> -core_initcall(rpmpd_init);
>> +module_init(rpmpd_init);
>
> Can't you keep this as core_initcall(), for the times when its builtin?
>
> Additionally I believe you should add a call to unregister the driver,

and implement a .remove?

> and drop the suppress_bind_attrs.
>
>> +MODULE_LICENSE("GPL");
>
> "GPL v2" per the SPDX?
>
> Regards,
> Bjorn
>
>> --
>> 2.17.1
>>

--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation

\
 
 \ /
  Last update: 2020-03-05 07:56    [W:0.103 / U:0.080 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site