Messages in this thread | ![/](/images/icornerl.gif) | | From | Avri Altman <> | Subject | RE: [PATCH v4 4/5] scsi: ufs-exynos: add UFS host support for Exynos SoCs | Date | Sat, 28 Mar 2020 11:28:26 +0000 |
| |
Hi,
> + > +long exynos_ufs_calc_time_cntr(struct exynos_ufs *ufs, long period) > +{ > + const int precise = 10; > + long pclk_rate = ufs->pclk_rate; > + long clk_period, fraction; > + > + clk_period = UNIPRO_PCLK_PERIOD(ufs); > + fraction = ((NSEC_PER_SEC % pclk_rate) * precise) / pclk_rate; > + > + return (period * precise) / ((clk_period * precise) + fraction); > +} This helper essentially calculates a factor f, and returns period x f. Why not do that regardless of period?
> +extern long exynos_ufs_calc_time_cntr(struct exynos_ufs *, long); Why this factor needed to be exported?
| ![\](/images/icornerr.gif) |