Messages in this thread | | | Date | Wed, 25 Mar 2020 13:31:29 -0500 | From | Bjorn Helgaas <> | Subject | Re: [PATCH v5 0/2] ACPI: APEI: Add support to notify the vendor specific HW errors |
| |
On Wed, Mar 25, 2020 at 04:27:15PM +0000, Shiju Jose wrote: > >-----Original Message----- > >From: Bjorn Helgaas [mailto:helgaas@kernel.org]
> >3) drivers/pci/controller/pcie-hisi-error.c should be next to > >drivers/pci/controller/dwc/pcie-hisi.c, shouldn't it? > > Our hip PCIe controller doesn't use DWC ip.
Ah, I was assuming this pcie-hisi-error.c driver was for the same device claimed by pcie-hisi.c.
Error drivers like this will have some device-specific knowledge (e.g., which registers to dump), but I guess they'll always be used with the generic acpi/pci_root.c driver, right?
It looks like this driver has little or nothing to do with the PCI core directly. It does include drivers/pci/pci.h, but I'm not sure it really needs it.
Maybe drivers/pci/controller/ is the best place for it, but I'm not sure. It's a little confusing because it's not really like the other things there.
There are some vaguely similar things in drivers/acpi/apei/ and drivers/acpi/nfit/. And of course there are .acpi_match_table uses all over the drivers/ tree. Maybe we need a new subdirectory under drivers/pci? drivers/pci/controller/apei/?
Any thoughts, Rafael?
Bjorn
| |