lkml.org 
[lkml]   [2020]   [Mar]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.5 28/65] mac80211: rx: avoid RCU list traversal under mutex
    Date
    From: Madhuparna Bhowmik <madhuparnabhowmik10@gmail.com>

    [ Upstream commit 253216ffb2a002a682c6f68bd3adff5b98b71de8 ]

    local->sta_mtx is held in __ieee80211_check_fast_rx_iface().
    No need to use list_for_each_entry_rcu() as it also requires
    a cond argument to avoid false lockdep warnings when not used in
    RCU read-side section (with CONFIG_PROVE_RCU_LIST).
    Therefore use list_for_each_entry();

    Signed-off-by: Madhuparna Bhowmik <madhuparnabhowmik10@gmail.com>
    Link: https://lore.kernel.org/r/20200223143302.15390-1-madhuparnabhowmik10@gmail.com
    Signed-off-by: Johannes Berg <johannes.berg@intel.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    net/mac80211/rx.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/net/mac80211/rx.c b/net/mac80211/rx.c
    index 0e05ff0376726..0ba98ad9bc854 100644
    --- a/net/mac80211/rx.c
    +++ b/net/mac80211/rx.c
    @@ -4114,7 +4114,7 @@ void __ieee80211_check_fast_rx_iface(struct ieee80211_sub_if_data *sdata)

    lockdep_assert_held(&local->sta_mtx);

    - list_for_each_entry_rcu(sta, &local->sta_list, list) {
    + list_for_each_entry(sta, &local->sta_list, list) {
    if (sdata != sta->sdata &&
    (!sta->sdata->bss || sta->sdata->bss != sdata->bss))
    continue;
    --
    2.20.1


    \
     
     \ /
      Last update: 2020-03-19 14:29    [W:4.138 / U:0.200 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site