Messages in this thread | | | Subject | Re: [PATCH v5 1/4] dt-bindings: Introduce SoC sleep stats bindings | From | Maulik Shah <> | Date | Thu, 19 Mar 2020 17:05:55 +0530 |
| |
Hi,
On 3/19/2020 2:59 AM, Stephen Boyd wrote: > Quoting Maulik Shah (2020-03-17 21:29:15) >> From: Mahesh Sivasubramanian <msivasub@codeaurora.org> >> >> Add device binding documentation for Qualcomm Technologies, Inc. (QTI) >> SoC sleep stats driver. The driver is used for displaying SoC sleep >> statistic maintained by Always On Processor or Resource Power Manager. >> >> Cc: devicetree@vger.kernel.org >> Signed-off-by: Mahesh Sivasubramanian <msivasub@codeaurora.org> >> Signed-off-by: Lina Iyer <ilina@codeaurora.org> >> Signed-off-by: Maulik Shah <mkshah@codeaurora.org> >> Reviewed-by: Rob Herring <robh@kernel.org> >> Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org> >> --- > Reviewed-by: Stephen Boyd <swboyd@chromium.org> Thanks Stephen. > > Two nits below. > >> diff --git a/Documentation/devicetree/bindings/soc/qcom/soc-sleep-stats.yaml b/Documentation/devicetree/bindings/soc/qcom/soc-sleep-stats.yaml >> new file mode 100644 >> index 0000000..d0c751d >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/soc/qcom/soc-sleep-stats.yaml >> @@ -0,0 +1,46 @@ > [...] >> + >> +examples: >> + # Example of rpmh sleep stats >> + - | >> + rpmh-sleep-stats@c3f0000 { > I would think 'memory' would be a more appropriate node name, but OK. > >> + compatible = "qcom,rpmh-sleep-stats"; >> + reg = <0 0xc3f0000 0 0x400>; > Please add a leading 0 to the address to pad it out to 8 digits. I will address this in v6. > >> + }; Thanks, Maulik
-- QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
| |