Messages in this thread | | | Subject | Re: [PATCH v7 0/6] block: Introduce REQ_ALLOCATE flag for REQ_OP_WRITE_ZEROES | From | Kirill Tkhai <> | Date | Thu, 19 Mar 2020 13:42:11 +0300 |
| |
On 19.03.2020 13:28, Christoph Hellwig wrote: > On Fri, Mar 13, 2020 at 04:08:58PM +0300, Kirill Tkhai wrote: >> I just don't understand the reason nothing happens :( >> I see newly-sent patches comes fast into block tree. >> But there is only silence... I grepped over Documentation, >> and there is no special rules about block tree. So, >> it looks like standard rules should be applyable. >> >> Some comments? Some requests for reworking? Some personal reasons to ignore my patches? > > I'm still completely opposed to the magic overloading using a flag. > That is just a bad design waiting for trouble to happen.
This flag is suggested by Martin Petersen, while the first version of the patchset was based on a separate operation.
Since I see only Jens in MAINTAINERS:
BLOCK LAYER M: Jens Axboe <axboe@kernel.dk> L: linux-block@vger.kernel.org T: git git://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git S: Maintained F: block/ F: drivers/block/ F: kernel/trace/blktrace.c F: lib/sbitmap.c
I expect his comments about final design of this, because both you and Martin are maintainers of another subsystems. I don't want rework this many times until Jens says he wants some third design.
I think I'm pretty polite and patient in my waiting, while Jens completely ignores me by some reasons, which are completely unclear for me. I don't think this is completely polite in relation to me.
Kirill
| |