Messages in this thread | | | Date | Thu, 19 Mar 2020 11:38:34 +0100 (CET) | From | Miroslav Benes <> | Subject | Re: [PATCH v2 2/2] x86/xen: Make the secondary CPU idle tasks reliable |
| |
On Thu, 19 Mar 2020, Jan Beulich wrote:
> On 19.03.2020 10:56, Miroslav Benes wrote: > > --- a/arch/x86/xen/smp_pv.c > > +++ b/arch/x86/xen/smp_pv.c > > @@ -53,6 +53,7 @@ static DEFINE_PER_CPU(struct xen_common_irq, xen_irq_work) = { .irq = -1 }; > > static DEFINE_PER_CPU(struct xen_common_irq, xen_pmu_irq) = { .irq = -1 }; > > > > static irqreturn_t xen_irq_work_interrupt(int irq, void *dev_id); > > +extern unsigned char asm_cpu_bringup_and_idle[]; > > Imo this would better reflect the actual type, i.e. be a function > decl. If left as an array one, I guess you may want to add const.
I sticked to what x86 has for secondary_startup_64. I can make it
void asm_cpu_bringup_and_idle(void);
Miroslav
| |