Messages in this thread | | | From | Thomas Gleixner <> | Subject | Re: [patch V2 08/15] Documentation: Add lock ordering and nesting documentation | Date | Thu, 19 Mar 2020 19:04:36 +0100 |
| |
Jonathan Corbet <corbet@lwn.net> writes: > On Wed, 18 Mar 2020 21:43:10 +0100 > Thomas Gleixner <tglx@linutronix.de> wrote: >> Add initial documentation. > > ...time to add a a couple of nits...:)
...time
Is that valid RST?
>> +++ b/Documentation/locking/locktypes.rst >> @@ -0,0 +1,298 @@ >> +.. _kernel_hacking_locktypes: >> + > > So ... I vaguely remember that some Thomas guy added a document saying we > should be putting SPDX tags on our files? :)
Never met him or heard about that.
>> + >> +The preferred solution is to use :c:func:`spin_lock_irq()` or >> +:c:func:`spin_lock_irqsave()` and their unlock counterparts. > > We don't need (and shouldn't use) :c:func: anymore; just saying > spin_lock_irq() will cause the Right Things to happen.
Good to know. Will fix.
Thanks,
tglx
| |