Messages in this thread | | | From | Daniel Vetter <> | Date | Thu, 19 Mar 2020 09:39:52 +0100 | Subject | Re: [PATCH v3] drm/bochs: downgrade pci_request_region failure from error to warning |
| |
On Wed, Mar 18, 2020 at 7:49 AM Gerd Hoffmann <kraxel@redhat.com> wrote: > > On Tue, Mar 17, 2020 at 05:49:41PM +0100, Daniel Vetter wrote: > > On Fri, Mar 13, 2020 at 09:41:52AM +0100, Gerd Hoffmann wrote: > > > Shutdown of firmware framebuffer has a bunch of problems. Because > > > of this the framebuffer region might still be reserved even after > > > drm_fb_helper_remove_conflicting_pci_framebuffers() returned. > > > > Is that still the fbdev lifetime fun where the cleanup might be delayed if > > the char device node is still open? > > Yes.
In that case I think a FIXME comment that this should be upgraded again to a full error once fbdev unloading is fixed should be added. With that:
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
I guess you might want a cc: stable on this too? -Daniel
> > cheers, > Gerd > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel
-- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch
| |