lkml.org 
[lkml]   [2020]   [Mar]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH] mm: hugetlb: fix hugetlb_cma_reserve() if CONFIG_NUMA isn't set
    From
    Date
    On Thu, 2020-03-19 at 17:16 +0100, Michal Hocko wrote:
    >
    > This is not the first time HAVE_MEMBLOCK_NODE_MAP has been
    > problematic.
    > I might be missing something but I really do not get why do we really
    > need it these days. As for !NUMA, I suspect we can make it generate
    > the
    > right thing when !NUMA.

    We're working on a different fix now.

    It looks like cma_declare_contiguous calls memblock_phys_alloc_range,
    which calls memblock_alloc_range_nid, which takes a NUMA node as one
    of its arguments.

    Aslan is looking at simply adding a cma_declare_contiguous_nid, which
    also takes a NUMA node ID as an argument. At that point we can simply
    leave CMA free to allocate from anywhere in each NUMA node, which by
    default already happens from the top down.

    That should be the nicer long term fix to this issue.

    --
    All Rights Reversed.
    [unhandled content-type:application/pgp-signature]
    \
     
     \ /
      Last update: 2020-03-19 17:57    [W:3.987 / U:0.000 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site