Messages in this thread | | | From | Linus Walleij <> | Date | Thu, 19 Mar 2020 15:14:27 +0100 | Subject | Re: [PATCH v2 2/5] dt-bindings: panel: add binding for Xingbangda XBD599 panel |
| |
Hi Icenowy,
On Mon, Mar 16, 2020 at 2:37 PM Icenowy Zheng <icenowy@aosc.io> wrote:
> Xingbangda XBD599 is a 5.99" 720x1440 MIPI-DSI LCD panel. > > Add its device tree binding. > > Signed-off-by: Icenowy Zheng <icenowy@aosc.io> (...)
> +properties: > + compatible: > + const: xingbangda,xbd599
As noticed in the review of the driver, this display is very close to himax,hx8363.
I think the best is to determin what actual display controller it is, I think it is some kind of Ilitek controller since Ilitek ili9342 is clearly very similar.
The best would be something like name the bindings ilitek-ili9342.yaml and then:
properties: compatible: items: - const: xingbangda,xbd599 - const: ilitek,ili9342
Possibly use oneOf and add support for the himax,hx8363 already while you're at it.
Yours, Linus Walleij
| |