Messages in this thread Patch in this message | ![/](/images/icornerl.gif) | | Date | Thu, 19 Mar 2020 14:10:43 -0000 | From | "tip-bot2 for Leo Yan" <> | Subject | [tip: perf/core] perf cs-etm: Fix unsigned variable comparison to zero |
| |
The following commit has been merged into the perf/core branch of tip:
Commit-ID: bc010dd657ee0309276c88ab828b9ad156f75b31 Gitweb: https://git.kernel.org/tip/bc010dd657ee0309276c88ab828b9ad156f75b31 Author: Leo Yan <leo.yan@linaro.org> AuthorDate: Wed, 19 Feb 2020 10:18:11 +08:00 Committer: Arnaldo Carvalho de Melo <acme@redhat.com> CommitterDate: Wed, 11 Mar 2020 10:48:44 -03:00
perf cs-etm: Fix unsigned variable comparison to zero
The variable 'offset' in function cs_etm__sample() is u64 type, it's not appropriate to check it with 'while (offset > 0)'; this patch changes to 'while (offset)'.
Signed-off-by: Leo Yan <leo.yan@linaro.org> Reviewed-by: Mathieu Poirier <mathieu.poirier@linaro.org> Reviewed-by: Mike Leach <mike.leach@linaro.org> Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com> Cc: Jiri Olsa <jolsa@redhat.com> Cc: Mark Rutland <mark.rutland@arm.com> Cc: Namhyung Kim <namhyung@kernel.org> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Robert Walker <robert.walker@arm.com> Cc: Suzuki Poulouse <suzuki.poulose@arm.com> Cc: coresight ml <coresight@lists.linaro.org> Cc: linux-arm-kernel@lists.infradead.org Link: http://lore.kernel.org/lkml/20200219021811.20067-6-leo.yan@linaro.org Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com> --- tools/perf/util/cs-etm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/util/cs-etm.c b/tools/perf/util/cs-etm.c index 87d9943..62d2f9b 100644 --- a/tools/perf/util/cs-etm.c +++ b/tools/perf/util/cs-etm.c @@ -962,7 +962,7 @@ static inline u64 cs_etm__instr_addr(struct cs_etm_queue *etmq, if (packet->isa == CS_ETM_ISA_T32) { u64 addr = packet->start_addr; - while (offset > 0) { + while (offset) { addr += cs_etm__t32_instr_size(etmq, trace_chan_id, addr); offset--;
| ![\](/images/icornerr.gif) |