Messages in this thread | | | From | Orson Zhai <> | Date | Thu, 19 Mar 2020 04:11:45 +0800 | Subject | Re: [RFC PATCH] dynamic_debug: Add config option of DYNAMIC_DEBUG_CORE |
| |
On Thu, Mar 19, 2020 at 3:23 AM Andy Shevchenko <andy.shevchenko@gmail.com> wrote: > > On Wed, Mar 18, 2020 at 9:04 PM Orson Zhai <orson.unisoc@gmail.com> wrote: > > > > There is the requirement from new Android that kernel image (GKI) and > > kernel modules are supposed to be built at differnet places. Some people > > want to enable dynamic debug for kernel modules only but not for kernel > > image itself with the consideration of binary size increased or more > > memory being used. > > > > By this patch, dynamic debug is divided into core part (the defination of > > functions) and macro replacement part. We can only have the core part to > > be built-in and do not have to activate the debug output from kenrel image. > > > > There are few grammar typos in above...
I am very sorry about this. I though check-patch would remind me, but it seems not. I'll check this carefully next time.
> > config DYNAMIC_DEBUG > > bool "Enable dynamic printk() support" > > default n > > > - depends on PRINTK > > - depends on DEBUG_FS > > You may not touch this. By removing them you effectively removed > dependencies :-(
OK. I thought dependencies it could be inherited from the selected one. But I believe you are right. It's not necessary to be removed. I will add it back at next version.
> > > + select DYNAMIC_DEBUG_CORE > > help > > > > Compiles debug level messages into the kernel, which would not > > @@ -164,6 +163,21 @@ config DYNAMIC_DEBUG > > See Documentation/admin-guide/dynamic-debug-howto.rst for additional > > information. > > > > +config DYNAMIC_DEBUG_CORE > > + bool "Enable core functions of dynamic debug support" > > + depends on PRINTK > > + depends on DEBUG_FS > > + help > > + Enable this option to build ddebug_* and __dynamic_* routines > > + into kernel. If you want enable whole dynamic debug features, > > + select CONFIG_DYNAMIC_DEBUG directly and this option will be > > + automatically selected. > > + > > + This option is selected when you want to enable dynamic debug > > > + for kernel modules only but not for the kernel base. Especailly > > Typo.
Will be fixed next version.
> > > + in the case that kernel modules are built out of the place where > > + kernel base is built. > > Highly recommend to ask somebody to do proof read.
Sorry again.
Thanks for your review.
Best Regards, -Orson > > -- > With Best Regards, > Andy Shevchenko
| |