Messages in this thread | | | From | Arnaldo Carvalho de Melo <> | Date | Wed, 18 Mar 2020 16:08:32 -0300 | Subject | Re: [PATCH v7 0/3] perf report: Support sorting by a given event in group |
| |
Em Wed, Mar 18, 2020 at 04:03:25PM -0300, Arnaldo Carvalho de Melo escreveu: > Em Wed, Mar 18, 2020 at 04:01:16PM -0300, Arnaldo Carvalho de Melo escreveu: > > Em Thu, Feb 20, 2020 at 09:36:13AM +0800, Jin Yao escreveu: > > > When performing "perf report --group", it shows the event group information > > > together. By default, the output is sorted by the first event in group. > > > It would be nice for user to select any event for sorting. > > > > > > The patch 1/3 introduces a new option "--group-sort-idx" to sort the > > > output by the event at the index n in event group. > > > > > > The patch 2/3 creates a new key K_RELOAD to reload the browser. > > > > > > The patch 3/3 supports hotkeys in browser to select a event to > > > sort. > > > > Thanks, applied. > > Doesn't work with 'perf top', should, investigating,
So needs a bit of work, but is doable and would be a great addition, since we do support:
# perf top --group -e instructions,cycles,cache-misses
And we should strive to make 'perf top' to be a perf.data-less, dynamic version of 'perf record + perf report'.
Can you please take a look at supporting this? And that --group-sort-idx too,
I'll push my perf/core branch after a few tests,
Thanks,
- Arnaldo
| |