Messages in this thread | | | From | John Ogness <> | Subject | Re: [RFC PATCH 0/3] Fix quiet console in pre-panic scenarios | Date | Wed, 18 Mar 2020 16:40:27 +0100 |
| |
On 2020-03-18, Eugeniu Rosca <erosca@de.adit-jv.com> wrote: > On Mon, Mar 16, 2020 at 08:09:48PM +0100, Sebastian Andrzej Siewior wrote: >> On 2020-03-16 14:35:17 [-0400], Steven Rostedt wrote: >> > I don't see any issues with this patch set. What do others think? >> > >> > Acked-by: Steven Rostedt (VMware) <rostedt@goodmis.org> >> > >> > [ Note, I only acked, and did not give a deep review of it ] >> >> What is the state of the other larger printk rework? If this does not >> solve any -stable related issues then it will be replaced? > > Is this a question to John and his most recent series in > https://lore.kernel.org/lkml/20200128161948.8524-1-john.ogness@linutronix.de/ > ? > > Is there any upstream agreement to already keep the current printk > mechanism away from any updates?
No. Fixes are welcome!
The only thing we are trying to avoid at this stage is massive refactoring/cleanup work. Your series does not fit into that category.
As to my opinion on this series, assuming it is acceptable for the maintainers, I would like to see console_verbose() become an alias to console_verbose_start(). Then @ignore_loglevel would be used for both and CONSOLE_LOGLEVEL_MOTORMOUTH could be removed.
John Ogness
| |