lkml.org 
[lkml]   [2020]   [Mar]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] Revert "x86/reboot, efi: Use EFI reboot for Acer TravelMate X514-51T"
Borislav Petkov <bp@alien8.de> 於 2020年3月16日 週一 下午6:01寫道:
>
> On Mon, Mar 16, 2020 at 05:17:56PM +0800, Jian-Hong Pan wrote:
> > But, that will raise another question: Since the original quirk works
> > for all Acer X514-51T and the quirk cannot be removed for older BIOS.
> > Why not keep only original matching items for all Acer X514-51T
> > laptops?
>
> What does the "original matching items" mean?

I should make it more clearly.

The quirk's original matching items for Acer TravelMate X514-51T from
commit 0082517fa4bc ("x86/reboot, efi: Use EFI reboot for Acer
TravelMate X514-51T"):

{ /* Handle reboot issue on Acer TravelMate X514-51T */
.callback = set_efi_reboot,
.ident = "Acer TravelMate X514-51T",
.matches = {
DMI_MATCH(DMI_SYS_VENDOR, "Acer"),
DMI_MATCH(DMI_PRODUCT_NAME, "TravelMate X514-51T"),
},
},

These matching items make all Acer TravelMate X514-51Ts apply the quirk.

If BIOS version condition is added like:

{ /* Handle reboot issue on Acer TravelMate X514-51T */
.callback = set_efi_reboot,
.ident = "Acer TravelMate X514-51T",
.matches = {
DMI_MATCH(DMI_SYS_VENDOR, "Acer"),
DMI_MATCH(DMI_PRODUCT_NAME, "TravelMate X514-51T"),
DMI_MATCH(DMI_BIOS_VERSION, "V1.0"),
},
},

Then, only Acer TravelMate X514-51T with older BIOS (1.04 and before,
according BIOS version listed on Acer's website [1]) will apply the
quirk.
The one with newer BIOS's reboot type will be defined later by the codes.

[1] https://www.acer.com/ac/en/US/content/support-product/7889?b=1

> > I am not sure which option is better. Any comment?
>
> If you mean, "let's not do anything and fix it only when there's really
> a need to fix anything", then yes, I agree.

Got it!

Thanks,
Jian-Hong Pan

\
 
 \ /
  Last update: 2020-03-18 08:00    [W:0.030 / U:0.064 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site