lkml.org 
[lkml]   [2020]   [Mar]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] fs/namespace: handle mount(MS_BIND|MS_REMOUNT) without locking sb->s_umount
On Wed, Mar 18, 2020 at 05:17:55PM +0300, Konstantin Khlebnikov wrote:
> @@ -459,11 +459,11 @@ void mnt_drop_write_file(struct file *file)
> }
> EXPORT_SYMBOL(mnt_drop_write_file);
>
> +/* mount_lock must be held */
> static int mnt_make_readonly(struct mount *mnt)
> {
> int ret = 0;
>
> - lock_mount_hash();

I'd rather see
+ lockdep_assert_held_write(&mount_lock);
than a comment. Maybe wrapped up into a macro like assert_hash_locked().

\
 
 \ /
  Last update: 2020-03-18 15:46    [W:0.025 / U:0.196 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site