Messages in this thread | | | From | Ju Hyung Park <> | Date | Wed, 18 Mar 2020 21:14:04 +0900 | Subject | Re: [PATCH v2] f2fs: use kmem_cache pool during inline xattr lookups |
| |
Hi Chao.
I got the time around to test this patch. The v2 patch seems to work just fine, and the code looks good.
On Tue, Feb 25, 2020 at 7:17 PM Chao Yu <yuchao0@huawei.com> wrote: > diff --git a/fs/f2fs/xattr.c b/fs/f2fs/xattr.c > index a3360a97e624..e46a10eb0e42 100644 > --- a/fs/f2fs/xattr.c > +++ b/fs/f2fs/xattr.c > @@ -23,6 +23,25 @@ > #include "xattr.h" > #include "segment.h" > > +static void *xattr_alloc(struct f2fs_sb_info *sbi, int size, bool *is_inline) > +{ > + *is_inline = (size == sbi->inline_xattr_slab_size);
Would it be meaningless to change this to the following code? if (likely(size == sbi->inline_xattr_slab_size)) *is_inline = true; else *is_inline = false;
The above statement seems to be only false during the initial mount and the rest(millions) seems to be always true.
Thanks.
| |