Messages in this thread | | | From | Song Liu <> | Subject | Re: [PATCH v2] perf/core: install cgroup events to correct cpuctx | Date | Wed, 18 Mar 2020 22:37:06 +0000 |
| |
> On Mar 18, 2020, at 12:33 PM, Peter Zijlstra <peterz@infradead.org> wrote: > > On Wed, Mar 18, 2020 at 07:05:35PM +0100, Peter Zijlstra wrote: >> On Wed, Mar 18, 2020 at 07:07:29AM +0000, Song Liu wrote: > >>> Could you please share your thoughts on this? I think we cannot use current >>> in list_update_cgroup_event(), unless we call it on the target CPU. >> >> Bah, that cgroup crap is 'wrong'. It's pointless to track the >> cpuctx->cgrp state for disabled events. >> >> Let me see if I can unravel that crud. > > This compiles, but I've no clue how to operate cgroups. Please test.
Thanks Peter! This fixes the issue I saw. And the code looks good too.
Reviewed-and-tested-by: Song Liu <songliubraving@fb.com>
[...]
| |