lkml.org 
[lkml]   [2020]   [Mar]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[GIT PULL 5/6] intel_th: Fix user-visible error codes
    Date
    There are a few places in the driver that end up returning ENOTSUPP to
    the user, replace those with EINVAL.

    Signed-off-by: Alexander Shishkin <alexander.shishkin@linux.intel.com>
    Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
    Fixes: ba82664c134ef ("intel_th: Add Memory Storage Unit driver")
    Cc: stable@vger.kernel.org # v4.4+
    ---
    drivers/hwtracing/intel_th/msu.c | 6 +++---
    1 file changed, 3 insertions(+), 3 deletions(-)

    diff --git a/drivers/hwtracing/intel_th/msu.c b/drivers/hwtracing/intel_th/msu.c
    index 7ac7dd4d3b1c..f08e9e883710 100644
    --- a/drivers/hwtracing/intel_th/msu.c
    +++ b/drivers/hwtracing/intel_th/msu.c
    @@ -765,7 +765,7 @@ static int msc_configure(struct msc *msc)
    lockdep_assert_held(&msc->buf_mutex);

    if (msc->mode > MSC_MODE_MULTI)
    - return -ENOTSUPP;
    + return -EINVAL;

    if (msc->mode == MSC_MODE_MULTI) {
    if (msc_win_set_lockout(msc->cur_win, WIN_READY, WIN_INUSE))
    @@ -1299,7 +1299,7 @@ static int msc_buffer_alloc(struct msc *msc, unsigned long *nr_pages,
    } else if (msc->mode == MSC_MODE_MULTI) {
    ret = msc_buffer_multi_alloc(msc, nr_pages, nr_wins);
    } else {
    - ret = -ENOTSUPP;
    + ret = -EINVAL;
    }

    if (!ret) {
    @@ -1535,7 +1535,7 @@ static ssize_t intel_th_msc_read(struct file *file, char __user *buf,
    if (ret >= 0)
    *ppos = iter->offset;
    } else {
    - ret = -ENOTSUPP;
    + ret = -EINVAL;
    }

    put_count:
    --
    2.25.1
    \
     
     \ /
      Last update: 2020-03-17 07:23    [W:5.875 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site