Messages in this thread | | | From | Pingfan Liu <> | Date | Tue, 17 Mar 2020 19:45:42 +0800 | Subject | Re: [PATCHv6 2/3] mm/gup: fix omission of check on FOLL_LONGTERM in gup fast path |
| |
On Mon, Mar 16, 2020 at 4:55 PM Christoph Hellwig <hch@infradead.org> wrote: > [...] > > Wrong indentation. We either align two tabs for continuation > statements, or after the opening brace of the previous line. With a > likely or unlikely thrown in the former IMHO looks much better. E.g. > > if (unlikely(flags & FOLL_LONGTERM) && > is_migrate_cma_page(page)) > return NULL; > OK, thanks. I will send out V7 to fix it.
Regards, Pingfan
| |