lkml.org 
[lkml]   [2020]   [Mar]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [RFC PATCH v2 3/6] mmc: host: Add UHS-II support in host layer
From
Date
On 9/01/20 11:14 am, Ben Chuang wrote:
> From: Ben Chuang <ben.chuang@genesyslogic.com.tw>
>
> Add UHS-II support in host layer

Split host layer changes from sdhci changes.

>
> Reported-by: kbuild test robot <lkp@intel.com>

Drop "Reported-by: kbuild test robot <lkp@intel.com>"

> Signed-off-by: Ben Chuang <ben.chuang@genesyslogic.com.tw>
> ---
> drivers/mmc/host/Makefile | 1 +
> drivers/mmc/host/{sdhci.c => sdhci-core.c} | 276 ++++++--
> drivers/mmc/host/sdhci-milbeaut.c | 4 +-
> drivers/mmc/host/sdhci-of-arasan.c | 4 +-
> drivers/mmc/host/sdhci-of-at91.c | 4 +-
> drivers/mmc/host/sdhci-omap.c | 2 +-
> drivers/mmc/host/sdhci-pci-core.c | 4 +-
> drivers/mmc/host/sdhci-pxav3.c | 4 +-
> drivers/mmc/host/sdhci-uhs2.c | 751 +++++++++++++++++++++
> drivers/mmc/host/sdhci-uhs2.h | 34 +
> drivers/mmc/host/sdhci-xenon.c | 4 +-
> drivers/mmc/host/sdhci.h | 284 +++++++-
> drivers/mmc/host/sdhci_am654.c | 4 +-
> include/linux/mmc/uhs2.h | 270 ++++++++
> 14 files changed, 1583 insertions(+), 63 deletions(-)
> rename drivers/mmc/host/{sdhci.c => sdhci-core.c} (94%)
> create mode 100644 drivers/mmc/host/sdhci-uhs2.c
> create mode 100644 drivers/mmc/host/sdhci-uhs2.h
> create mode 100644 include/linux/mmc/uhs2.h

Please make sdhci-uhs2 a module and do not rename sdhci.c.

References in sdhci.c to sdhci-uhs2.c will need to be enclosed by
#if IS_REACHABLE(CONFIG_SDHCI_UHS2)

Move all UHS-II definitions into sdhci-uhs2.h. Things that are for V4 but
not necessarily UHS-II can be in sdhci.h

Make the set_power parameter change into a separate patch

Fix all spelling mistakes

Make comment style correct.

Review all checkpatch warnings and checks (i.e. --strict option)

If possible provide a link to a tree that contains the patches.

Re-base on Ulf's next branch

The patch set could use an overview of how UHS-II is different from regular SD.

In other patches there are a bunch of memory allocations on the I/O path.
That is a problem. Memory needed should be allocated in advance.

\
 
 \ /
  Last update: 2020-03-17 09:19    [W:0.147 / U:0.072 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site