lkml.org 
[lkml]   [2020]   [Mar]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v3 1/2] Revert "net: mvmdio: avoid error message for optional IRQ"
    Date
    This reverts commit e1f550dc44a4d535da4e25ada1b0eaf8f3417929.
    platform_get_irq_optional() will still return -ENXIO when no interrupt
    is provided so the additional error handling caused the driver prone to
    fail when no interrupt was specified. Revert the change so we can apply
    the correct minimal fix.

    Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
    ---
    drivers/net/ethernet/marvell/mvmdio.c | 6 +++---
    1 file changed, 3 insertions(+), 3 deletions(-)

    diff --git a/drivers/net/ethernet/marvell/mvmdio.c b/drivers/net/ethernet/marvell/mvmdio.c
    index d2e2dc538428..0b9e851f3da4 100644
    --- a/drivers/net/ethernet/marvell/mvmdio.c
    +++ b/drivers/net/ethernet/marvell/mvmdio.c
    @@ -347,7 +347,7 @@ static int orion_mdio_probe(struct platform_device *pdev)
    }


    - dev->err_interrupt = platform_get_irq_optional(pdev, 0);
    + dev->err_interrupt = platform_get_irq(pdev, 0);
    if (dev->err_interrupt > 0 &&
    resource_size(r) < MVMDIO_ERR_INT_MASK + 4) {
    dev_err(&pdev->dev,
    @@ -364,8 +364,8 @@ static int orion_mdio_probe(struct platform_device *pdev)
    writel(MVMDIO_ERR_INT_SMI_DONE,
    dev->regs + MVMDIO_ERR_INT_MASK);

    - } else if (dev->err_interrupt < 0) {
    - ret = dev->err_interrupt;
    + } else if (dev->err_interrupt == -EPROBE_DEFER) {
    + ret = -EPROBE_DEFER;
    goto out_mdio;
    }

    --
    2.25.1
    \
     
     \ /
      Last update: 2020-03-16 08:50    [W:3.050 / U:0.528 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site