lkml.org 
[lkml]   [2020]   [Dec]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH net v1] net: dsa: qca: ar9331: fix sleeping function called from invalid context bug
On Fri, Dec 04, 2020 at 04:00:35PM +0100, Marc Kleine-Budde wrote:
> On 12/4/20 3:57 PM, Oleksij Rempel wrote:
> [...]
>
>
> > +static void ar9331_sw_irq_bus_sync_unlock(struct irq_data *d)
> > {
> > struct ar9331_sw_priv *priv = irq_data_get_irq_chip_data(d);
> > struct regmap *regmap = priv->regmap;
> > int ret;
> >
> > ret = regmap_update_bits(regmap, AR9331_SW_REG_GINT_MASK,
> > - AR9331_SW_GINT_PHY_INT,
> > - AR9331_SW_GINT_PHY_INT);
> > + AR9331_SW_GINT_PHY_INT, priv->irq_mask);
> > if (ret)
> > - dev_err(priv->dev, "could not unmask IRQ\n");
> > + dev_err(priv->dev, "could not mask IRQ\n");
>
> Technically this could be a mask or unmask operation. What about changing the
> error message to: "faild to change IRQ mask"?

OK, it make sense. I'll fix it.

Regards,
Oleksij
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |

\
 
 \ /
  Last update: 2020-12-09 14:14    [W:0.057 / U:0.120 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site