lkml.org 
[lkml]   [2020]   [Dec]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [Patch v3 0/2] cgroup: KVM: New Encryption IDs cgroup controller
Hello,

Rough take after skimming:

* I don't have an overall objection. In terms of behavior, the only thing
which stood out was input rejection depending on the current usage. The
preferred way of handling that is rejecting future allocations rather than
failing configuration as that makes it impossible e.g. to lower limit and
drain existing usages from outside the container.

* However, the boilerplate to usefulness ratio doesn't look too good and I
wonder whether what we should do is adding a generic "misc" controller
which can host this sort of static hierarchical counting. I'll think more
on it.

Thanks.

--
tejun

\
 
 \ /
  Last update: 2020-12-09 22:01    [W:0.048 / U:0.744 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site